javascript not working

notexistant · **Posted:** Thu Aug 06, 2009 8:59 pm

Code:

<?php
define("IN_MYBB", 1);
define("NO_ONLINE", 1);
require("forums/global.php");
if(!$mybb->user['uid'])
{
echo "<form name='login' action='forums/member.php' method='post'>
<table width='100%' border='0'>
<tr>
<td colspan='2' height='30px' background='/forums/images/ArchGames/thead_bg.png'>
<a href=''><img border='0' style='float: right;' onclick='self.parent.tb_remove();' src='/images/close.png' /></a>
</td>
</tr>
<tr>
<td align='right'>
Username:
</td>
<td align='left'>
<input type='text' name='username' size='25' maxlength='30' />
</td>
</tr>
<tr>
<td align='right'>
Password:
</td>
<td align='left'>
<input type='password' name='password' size='25' />
</td>
</tr>
<tr>
<td colspan='2'>
<input type='hidden' name='action' value='do_login'>
<input type='hidden' name='url' value='' />
<input type='submit' class='submit' name='submit' value='Login' />
</td>
</tr>
</table>
</form>";
}
?>
<script type="text/javascript">
document.login.url.value = parent.location.href;
</script>

Anyone know why?

Sephiroth187 · **Posted:** Fri Aug 07, 2009 1:18 am

change

parent.location.href

to

window.location.href

or window.location is fine in itself.

But I assume your using an iFrame so

parent.window.location.href

notexistant · **Posted:** Fri Aug 07, 2009 4:14 am

Nope, still didn't work.

Sephiroth187 · **Posted:** Fri Aug 07, 2009 1:12 pm

Oh shit I wasn't thinking properly, you have to access objects using the DOM standard, the method you pulled only works in something like firefox I think.

Code:

<?php
define("IN_MYBB", 1);
define("NO_ONLINE", 1);
require("forums/global.php");
if(!$mybb->user['uid'])
{
echo "<form name='login' action='forums/member.php' method='post'>
<table width='100%' border='0'>
<tr>
<td colspan='2' height='30px' background='/forums/images/ArchGames/thead_bg.png'>
<a href=''><img border='0' style='float: right;' onclick='self.parent.tb_remove();' src='/images/close.png' /></a>
</td>
</tr>
<tr>
<td align='right'>
Username:
</td>
<td align='left'>
<input type='text' name='username' size='25' maxlength='30' />
</td>
</tr>
<tr>
<td align='right'>
Password:
</td>
<td align='left'>
<input type='password' name='password' size='25' />
</td>
</tr>
<tr>
<td colspan='2'>
<input type='hidden' name='action' value='do_login'>
<input type='hidden' name='url' value='' />
<input type='submit' class='submit' name='submit' value='Login' />
</td>
</tr>
</table>
</form>";
}
?>
<script type="text/javascript">
var o_url  = document.getElementsByName['url'][0]
o_url.value = parent.location.href;
</script>

Right I wasn't thinking last night sorry.

notexistant · **Posted:** Fri Aug 07, 2009 1:14 pm

You see it doesn't work an I'm using firefox. Also even a simple alert message doesn't show. I'll try what you posted when I get home though.

Sephiroth187 · **Posted:** Fri Aug 07, 2009 1:38 pm

It was either an old method in firefox or IE I forget, but its unsupported.

Also if you want a better understanding of your errors try

try {
...
} catch (ex) {
alert(ex.message);
}

notexistant · **Posted:** Sat Aug 08, 2009 1:41 am

Your code...

Code:

<script type="text/javascript">
var o_url  = document.getElementsByName['url'][0]
o_url.value = parent.location.href;
</script>

Returns:

Quote:

document.getElementsByName.url is undefined

The one I was using returns no error is just doesn't work. The source reads...

Code:

When it should read...

Code:

Also the first code you gave me also returns no error it just doesn't set value to the parent frame like my first issue. If I change it to an alert box like so...

Code:

<script type="text/javascript">
alert(parent.window.location.href);
</script>

or

Code:

<script type="text/javascript">
alert(parent.location.href);
</script>

Both give me the correct url.

Sephiroth187 · **Posted:** Sat Aug 08, 2009 2:49 am

Ok WHAT kind of browser are you even using? [and best of all what version]

It shouldn't even return 'document.getElementsByName.url is undefined', in that written format.

notexistant · **Posted:** Sat Aug 08, 2009 2:58 am

Firefox 3.5

Also IE 8 says...

Attachment:

ie.PNG

Sephiroth187 · **Posted:** Sat Aug 08, 2009 3:14 pm

Oh man I never check before I wrote, I was ment to do

document.getElementsByName("url")[0]

Haha, I never make that mistake... :oops:

notexistant · **Posted:** Sun Aug 09, 2009 12:10 am

OK, well I don't get an error now but it still doesn't work. The url field in the form still reads...

Code:

Sephiroth187 · **Posted:** Sun Aug 09, 2009 2:36 am

It wont change the code when you try to view source.

Just try do an

Code:

<script>
   var obj = doucment.getElementsByName("url")[0];
   alert(obj.value);
</script>

To make sure it works

notexistant · **Posted:** Sun Aug 09, 2009 3:04 am

Woo, it works! xD Thanks! Wow, I wonder if any of the others would have worked even the original one because I never checked to see if it worked I just always looked at the source.

Sephiroth187 · **Posted:** Sun Aug 09, 2009 2:26 pm

Hahahaha

I just can't believe I was so slow in this XD

ShadowMaster · **Posted:** Sun Aug 09, 2009 4:49 pm

You getting there

vbGore Free Online RPG Engine

javascript not working